Re: breakpoint error messages

[Michael Snyder <msnyder at redhat dot com>]

Grace Sainsbury wrote:
> 
> I changed insert_breakpoints to collect all the warning messages from
> failed inserts and print them with an error after trying the whole
> queue. This changes the functionality slightly -- the old code stopped
> after the first failed insert of a breakpoint. I also changed the
> error messages to be more explicit about hardware breakpoints.
> 
> ok?

Grace, thanks for the contribution.  A few implementation details.
First off, you've lost some output.
1) The word "Warning: ", which is generated by the 'warning' function
(which you've replaced by fprintf_unfiltered).  One instance would
probably be enough.
2) The output of the 'memory_error' function.
3) The msg "The same program may be running in another process"
4) The output of print_sys_errmsg, formerly called by infrun.

Do you think you could work those back in?

Then, just some textual edits.  In one comment you say
"If there wat an error", where you probably meant to say 'was'.
And there's this:
    if (hw_breakpoint_error)
       fprintf_unfiltered (tmp_error_stream, 
		"Could not insert breakpoints: ..."

Seems like you might as well say "hardware breakpoints" there.

Regards,
Michael

> 
> grace
> 
> 2002-08-21  Grace Sainsbury  <graces@redhat.com>
> 
>         * infrun.c (normal_stop, proceed): Remove call to print_sys_errmsg
>         when breakpoints fail. Move general breakpoint error messages to
>         insert_breakpoints.
>         * breakpoint.c (insert_breakpoints): Change warnings when
>         breakpoints are nto inserted to specify the type. Remove call to
>         memory_error when breakpoints can't be inserted. Remove multiple
>         calls to warning so all messages are sent to the user at once.
>         (delete_breakpoints): Make insert error messsages more explicit.
> 
>   ------------------------------------------------------------------------
> 
>    patchName: patch
>         Type: Plain Text (text/plain)