This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Minor reformatting in infrun.c


Joel Brobecker wrote:
> 
> > I hate long lines as much as anybody, but I hate defeating indent
> > even more.  The middle part of this is just going to go back to
> > the right again, the first time indent gets run.
> >
> > You might prefer to have it happen under your control...
> 
> Argh! That's right! Thanks.
> 
> After adding the followig dummy comment, the "indent"-ed version stays
> very close to the hand-formatted version. Should I check it in?
> (note, the attached patch does not include the changes introduced after
> running gdb_indent).

Err, I was actually meaning to say "let's conform with indent", 
rather than "let's defeat indent".  How about moving the comment
outside the argument list?  Then the args can stay as they were.

> 
> 2002-08-22  Joel Brobecker  <brobecker@gnat.com>
> 
>         * infrun.c (handle_inferior_event): Add a dummy comment to
>         help indent find a more readable formatting of this line of code.
> 
> Thanks,
> --
> Joel
> 
>   ------------------------------------------------------------------------
> 
>    infrun.c.diffName: infrun.c.diff
>                 Type: Plain Text (text/plain)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]