This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa;Testsuite] test complaints interface


Looks good.  Pls. check it in.

Thanks for the new tests.

Regards,
Fernando

Andrew Cagney wrote:
Hello,

The attached patch adds tests for the new complaints interface.

Turns out that testing this was a good move. Although I modified symtab.c to use the new interface, all the calls are wrapped in #if 0 so will never ever be called.

ok?

Andrew


------------------------------------------------------------------------

2002-09-18 Andrew Cagney <ac131313@redhat.com>

* gdb.gdb/complaints.exp: New file.

Index: testsuite/gdb.gdb/complaints.exp
===================================================================
RCS file: testsuite/gdb.gdb/complaints.exp
diff -N testsuite/gdb.gdb/complaints.exp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ testsuite/gdb.gdb/complaints.exp 19 Sep 2002 00:46:02 -0000
@@ -0,0 +1,282 @@
+# Copyright 2002
+# Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+# +# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+# +# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. +
+# Please email any bugs, comments, and/or additions to this file to:
+# bug-gdb@prep.ai.mit.edu
+
+# This file was written by Andrew Cagney (cagney at redhat dot com),
+# derived from xfullpath.exp (written by Joel Brobecker), derived from
+# selftest.exp (written by Rob Savoye).
+
+if $tracelevel then {
+ strace $tracelevel
+}
+
+set prms_id 0
+set bug_id 0
+
+# are we on a target board
+if [is_remote target] {
+ return
+}
+
+proc setup_test { executable } {
+ global gdb_prompt
+ global timeout
+
+ # load yourself into the debugger
+ # This can take a relatively long time, particularly for testing where
+ # the executable is being accessed over a network, or where gdb does not
+ # support partial symbols for a particular target and has to load the
+ # entire symbol table. Set the timeout to 10 minutes, which should be
+ # adequate for most environments (it *has* timed out with 5 min on a
+ # SPARCstation SLC under moderate load, so this isn't unreasonable).
+ # After gdb is started, set the timeout to 30 seconds for the duration
+ # of this test, and then back to the original value.
+
+ set oldtimeout $timeout
+ set timeout 600
+ verbose "Timeout is now $timeout seconds" 2
+ if {[gdb_load $executable] <0} then {
+ set timeout $oldtimeout
+ verbose "Timeout is now $timeout seconds" 2
+ return -1
+ }
+ set timeout $oldtimeout
+ verbose "Timeout is now $timeout seconds" 2
+
+ # Set a breakpoint at main
+ gdb_test "break captured_command_loop" \
+ "Breakpoint.*at.* file.*, line.*" \
+ "breakpoint in captured_command_loop"
+
+ # run yourself
+ # It may take a very long time for the inferior gdb to start (lynx),
+ # so we bump it back up for the duration of this command.
+ set timeout 600
+
+ set description "run until breakpoint at captured_command_loop"
+ send_gdb "run -nw\n"
+ gdb_expect {
+ -re "Starting program.*Breakpoint \[0-9\]+,.*captured_command_loop .data.* at .*main.c:.*$gdb_prompt $" {
+ pass "$description"
+ }
+ -re "Starting program.*Breakpoint \[0-9\]+,.*captured_command_loop .data.*$gdb_prompt $" {
+ xfail "$description (line numbers scrambled?)"
+ }
+ -re "vfork: No more processes.*$gdb_prompt $" {
+ fail "$description (out of virtual memory)"
+ set timeout $oldtimeout
+ verbose "Timeout is now $timeout seconds" 2
+ return -1
+ }
+ -re ".*$gdb_prompt $" {
+ fail "$description"
+ set timeout $oldtimeout
+ verbose "Timeout is now $timeout seconds" 2
+ return -1
+ }
+ timeout {
+ fail "$description (timeout)"
+ }
+ }
+
+ set timeout $oldtimeout
+ verbose "Timeout is now $timeout seconds" 2
+
+ return 0
+}
+
+proc test_isolated_complaints { } {
+
+ global gdb_prompt
+
+ # Unsupress complaints
+ gdb_test "set stop_whining = 2"
+
+ # Prime the system
+ gdb_test "call complaint (&symfile_complaints, \"Register a complaint\")" \
+ "During symbol reading, Register a complaint."
+
+ # Check that the complaint was inserted and where
+ gdb_test "print symfile_complaints->root->fmt" \
+ ".\[0-9\]+ =.*\"Register a complaint\""
+
+ # Re-issue the first message #1
+ gdb_test "call complaint (&symfile_complaints, symfile_complaints->root->fmt)" \
+ "During symbol reading, Register a complaint."
+
+ # Check that there is only one thing in the list
+ gdb_test "print symfile_complaints->root->next == &complaint_sentinel" \
+ ".\[0-9\]+ = 1" "list has one entry"
+
+ # Add a second complaint, expect it
+ gdb_test "call complaint (&symfile_complaints, \"Testing! Testing! Testing!\")" \
+ "During symbol reading, Testing. Testing. Testing.."
+
+ return 0
+}
+
+proc test_serial_complaints { } {
+
+ global gdb_prompt
+
+ gdb_test_exact "call clear_complaints (&symfile_complaints, 1, 0)" "" "serial start"
+
+ # Prime the system
+ send_gdb "call complaint (&symfile_complaints, \"serial line 1\")\n"
+ gdb_expect {
+ -re "During symbol reading...serial line 1...$gdb_prompt " {
+ pass "serial line 1"
+ }
+ "$gdb_prompt" {
+ fail "serial line 1"
+ }
+ timeout {
+ fail "serial line 1 (timeout)"
+ }
+ }
+
+ # Add a second complaint, expect it
+ send_gdb "call complaint (&symfile_complaints, \"serial line 2\")\n"
+ gdb_expect {
+ -re "serial line 2...$gdb_prompt " {
+ pass "serial line 2"
+ }
+ "$gdb_prompt" {
+ fail "serial line 2"
+ }
+ timeout {
+ fail "serial line 2 (timeout)"
+ }
+ }
+
+ send_gdb "call clear_complaints (&symfile_complaints, 1, 0)\n"
+ gdb_expect {
+ -re "\r\n\r\n$gdb_prompt " {
+ pass "serial end"
+ }
+ "$gdb_prompt" {
+ fail "serial end"
+ }
+ timeout {
+ fail "serial end (timeout)"
+ }
+ }
+
+ return 0
+}
+
+# For short complaints, all are the same
+
+proc test_short_complaints { } {
+
+ global gdb_prompt
+
+ gdb_test_exact "call clear_complaints (&symfile_complaints, 1, 1)" "" "short start"
+
+ # Prime the system
+ send_gdb "call complaint (&symfile_complaints, \"short line 1\")\n"
+ gdb_expect {
+ -re "short line 1...$gdb_prompt " {
+ pass "short line 1"
+ }
+ "$gdb_prompt" {
+ fail "short line 1"
+ }
+ timeout {
+ fail "short line 1 (timeout)"
+ }
+ }
+
+ # Add a second complaint, expect it
+ send_gdb "call complaint (&symfile_complaints, \"short line 2\")\n"
+ gdb_expect {
+ -re "short line 2...$gdb_prompt " {
+ pass "short line 2"
+ }
+ "$gdb_prompt" {
+ fail "short line 2"
+ }
+ timeout {
+ fail "short line 2 (timeout)"
+ }
+ }
+
+ send_gdb "call clear_complaints (&symfile_complaints, 1, 0)\n"
+ gdb_expect {
+ -re "\r\n\r\n$gdb_prompt " {
+ pass "short end"
+ }
+ "$gdb_prompt" {
+ fail "short end"
+ }
+ timeout {
+ fail "short end (timeout)"
+ }
+ }
+
+ return 0
+}
+
+# Find a pathname to a file that we would execute if the shell was asked
+# to run $arg using the current PATH.
+
+proc find_gdb { arg } {
+
+ # If the arg directly specifies an existing executable file, then
+ # simply use it.
+
+ if [file executable $arg] then {
+ return $arg
+ }
+
+ set result [which $arg]
+ if [string match "/" [ string range $result 0 0 ]] then {
+ return $result
+ }
+
+ # If everything fails, just return the unqualified pathname as default
+ # and hope for best.
+
+ return $arg
+}
+
+# Run the test with self.
+# Copy the file executable file in case this OS doesn't like to edit its own
+# text space.
+
+set GDB_FULLPATH [find_gdb $GDB]
+
+# Remove any old copy lying around.
+remote_file host delete x$tool
+
+gdb_start
+
+set file [remote_download host $GDB_FULLPATH x$tool]
+
+set setup_result [setup_test $file ]
+if {$setup_result <0} then {
+ return -1
+}
+
+test_isolated_complaints
+test_serial_complaints
+test_short_complaints
+
+gdb_exit;
+catch "remote_file host delete $file";

--
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]