This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Preliminary check-in of ObjC support


Andrew Cagney wrote:



> 2002-09-18  Michael Snyder  <msnyder@redhat.com>
>
>       * objc-lang.c: New file, support for Objective-C.
>       Preliminary check-in, not yet integrated into gdb.
>       * objc-lang.h: New file.
>       * objc-exp.y:  New file.
>

Not unepxected, the ARI picked up a number of coding style problems.

Andrew, I thought you told me to check in the files, THEN
fix the ARI issues.  That's exactly what I did.
Yes, that is right. Take a preliminary stab at cleaning up the new files, commit them, and then find out what was missed. (There should be a script to do this but there isn't :-( ).

After that is merging in the other changes. I should have been clearer here (sorry). Break the changes down and get each in in turn. Some can be grouped and are pretty obvious. Many, however, need review by a number of maintainers so that we can be sure that the change is addressing the underlying problem.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]