This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for gdb/mi problem 192


gdb/ChangeLog:

2002-09-30  Jeff Johnston  <jjohnstn@redhat.com>

	* ui-out.h (ui_out_field_fmt_int): New prototype.
	* ui-out.c (ui_out_field_fmt_int): New function allowing specification
	of field width and alignment.
	* stack.c (print_frame_info_base): When printing frame level, use
	ui_out_field_fmt_int with a width of 2 and left alignment.  Fix for
	PR gdb/192
Ok, so instead of:
frame="2 "
it outputs
frame="2"
I think this is a straight bug that can't (?) affect old parsers (...).

So, yes, ok.

Can you just add a NEWS entry pointing out that this was fixed. You'll now also need to update both mi-*.exp and mi1-*.exp.

gdb/testsuite/gdb.mi/ChangeLog:

2002-09-30  Jeff Johnston  <jjohnstn@redhat.com>

	* mi-stack.exp: Change testcases that print frame to not expect "level" field
	to have extraneous right space.  Fix for PR gdb/192.
	* mi-return.exp: Ditto.

Also (independant patch) can you please mention this new ui_out_field_fmt_int() function in the gdbint.texinfo doco (look for ui_out_field_int()). If Eli is ok with it, then it is approved.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]