This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] ARI fixes fro objc-lang.[ch]
- From: Kevin Buettner <kevinb at redhat dot com>
- To: Adam Fedor <fedor at doc dot com>, gdb-patches at sources dot redhat dot com
- Date: Thu, 3 Oct 2002 16:50:18 -0700
- Subject: Re: [PATCH] ARI fixes fro objc-lang.[ch]
- References: <3D9BAE8E.7000804@doc.com>
On Oct 2, 8:42pm, Adam Fedor wrote:
> 2002-10-02 Adam Fedor <fedor@gnu.org>
>
> * objc-lang.c: ARI fixes. Change string.h to gdb_string.h
> (objc_demangle): Remove assignment in if statements, free->xfree
> (add_msglist): Likewise.
> (end_msglist): Likewise.
> (complare_selectors): Likewise.
> (selectors_info): Likewise.
> (compare_classes): Likewise.
> (classes_info): Likewise.
> (print_object_command): Likewise.
> (find_objc_msgcall_submethod): PTR->void *
> * objc-lang.h: Remove check for __STDC__
The patch looks good to me. I think it's okay to check it in.
Regarding the format of your ChangeLog entries though...
1) Check your ChangeLog entry indentation. It looks to me like
you're indenting by nine spaces. (A single tab is usually
used, though there are a few entries scattered about which
use eight spaces instead.)
2) Make sure that each sentence ends with a period.
3) If a period does not end the line, make sure that there are
two spaces between it and the next non-blank character.
4) [Now I'm really picking at nits...] I'd rather see:
(find_objc_msgcall_submethod): Replace ``PTR'' with ``void *''.
instead of:
(find_objc_msgcall_submethod): PTR->void *.
Kevin