This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Patch for gdb/mi problem 702
- From: Keith Seitz <keiths at redhat dot com>
- To: "J. Johnston" <jjohnstn at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, <alain at qnx dot com>
- Date: Thu, 3 Oct 2002 17:24:47 -0700 (PDT)
- Subject: Re: Patch for gdb/mi problem 702
On Thu, 3 Oct 2002, J. Johnston wrote:
> The following fixes a problem with -var-assign whereby an assignment
> of a new value is not seen by a subsequent -var-update. The
> underlying varobj_update call looks to see if there is a difference
> between the current value and a refreshed value. Since varobj_set_value
> actually changes both the internal value and the actual value, varobj_update
> does not add the variable to the changelist.
The real question is: is it really necessary for an assignment to show up
in the udpate list. IMO, it doesn't matter, because the caller will know if
the assignment succeeded or failed. If it failed, it'll have an error
message from MI. Otherwise, it knows that it worked and all it needs to do
is fetch the value of this variable (to get the right display format) and
update the displayed value on the screen. There's no reason to do an
update, which is not a cheap operation.
I really don't know what to make of this. I don't think this is really
necessary. It seems like a substitute for error checking.
Perhaps Alain can comment on why this is necessary with Eclipse?
Keith