This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Print vector registers in natural format, not hex


Just got one nit.

On Fri, Oct 04, 2002 at 04:41:48PM -0400, Klee Dienes wrote:
> Before: 
> 
> (gdb) show architecture 
> The target architecture is set automatically (currently powerpc:common) 

>   v16_int8 = {0x60, 0x61, 0x62, 0x63, 0x64, 0x65, 0x66, 0x67, 0x40, 
> 0x49, 0xf, 0xdb, 0x40, 0x2d, 0xf8, 0x54} 

> After: 

>   v16_int8 = "`abcdefg@I\017°Z@-°ZT" 

First of all, in characters
  v16_int8 = {'`', 'a', 'b', 'c', 'd', 'e', 'f', 'g', '@', 'I', '\017', '°', 'Z', '@', '-', '°', 'Z', 'T'}

is more natural to me.  It's a vector of chars, not a string.

Secondly, this is an 'int8' type.  Are characters really the way to go?


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]