This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA/RFC] Address class support
- From: Eli Zaretskii <eliz at is dot elta dot co dot il>
- To: Kevin Buettner <kevinb at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Thu, 17 Oct 2002 08:39:23 +0200 (IST)
- Subject: Re: [PATCH RFA/RFC] Address class support
On 16 Oct 2002, Jim Blandy wrote:
> The dwarf2read.c part is approved.
Sorry, Kevin it seems like I overlooked the original RFA.
> > As before, I'll need approval on the dwarf2read.c changes from
> > either Jim or Elena and I'll need Eli's okay on the Docs changes.
Approved, with the following comments/suggestions:
> +@deftypefn {Target Macro} int ADDRESS_CLASS_TYPE_FLAGS (int @var{byte_size}, int @var{dwarf2_addr_class})
Do you really need to use @var inside deftypefn (I don't have the Texinfo
manual handy, sorry)? I thought the @def... directives supply the @var
automatically.
> +Consider a hypothetical architecture in which addresses are normally
> +32-bits wide, but 16-bit addresses are also supported. Furthermore,
> +suppose that the DWARF 2 information for this architecture simply
I suggest to use either DWARF2 or @w{DWARF 2}, to prevent TeX and makeinfo
from splitting this between DWARF and 2.
> +@smallexample
> +somearch_address_class_type_flags (int byte_size, int dwarf2_addr_class)
This line is too long (even for @smallexample), so please break it in
two:
+somearch_address_class_type_flags (int byte_size,
+ int dwarf2_addr_class)
(There are more too long lines in your examples. In general, any line
inside @smallexample that is longer than 64 characters should be broken
into several lines, or else it will cause overfull hbox'es when you TeX
the manual.)