This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Redefine skip_quoted
Elena Zannoni wrote:
Adam Fedor writes:
> Jim Blandy wrote:
> > Klee Dienes <klee@apple.com> writes:
> >
> >>In the Apple code, we use skip_quoted to allow for the possibility of
> >>spaces in Objective-C function names.
> >>
> >>I'm actually coming to think that allowing people to break on unquoted
> >>Objective-C methods was a mistake: it's caused us no end of trouble
> >>trying to shoehorn decode_line_1() into handling every possible
> >>edge-case. I'm not sure how practical it is for us to remove it at
> >>this point, though --- we'd have to do some research among our
> >>Objective-C developers to find out how important a feature it is to
> >>them, I think.
> >
> >
> > So, the original patch posted is preparation for a behavior which you
> > now suspect was a mistake, and which has caused you no end of trouble?
> > (Or do I have the sense of what you were saying reversed?) You can
> > forgive me if hearing that makes me a bit hesitant to approve the
> > patch, right? :)
> >
>
> Well, really the use of skip_quoted for ObjC (in a patch that I haven't
> submitted yet), really has more to do with handling the canonical form
> of an Objective-C method symbol (e.g. -[MyObject myMethod:arg2:]) that
> comes from objc-lang.c. Most of the breakpoint cases that a user would
> enter are handled elsewhere (in a patch that I also haven't submitted).
>
I have to agree with Jim here, I think we should wait on the parts you
haven't submitted before deciding on this one. Could you just have
added the chars you need to the gdb_completer_word_break_characters
variable?
No. It involves removing characters. Another option would be to define a
new function, say skip_objc_quoted, just for objc which would be similar
to skip_quoted. How about that?
--
Adam Fedor, Digital Optics Corp. | I'm glad I hate spinach, because
http://www.doc.com | if I didn't, I'd eat it, and you
| know how I hate the stuff.