Re: [RFA] Use vfork in shell_escape

[Michael Snyder <msnyder at redhat dot com>]

Daniel Jacobowitz wrote:
> 
> This patch is pretty obvious.  I couldn't figure out why my machine was
> running out of memory; forking GDB to run an 'ls' during the maint.exp tests
> can be a bit heavy, since it may have all of glibc's debug info loaded.
> This patch seems logical to me... OK to commit?

Not as is.  There's some auto-confery involved, since many systems
(some systems?) don't have vfork.  Grep for vfork in fork-child.c.

> 
> --
> Daniel Jacobowitz
> MontaVista Software                         Debian GNU/Linux Developer
> 
> 2002-10-21  Daniel Jacobowitz  <drow@mvista.com>
> 
>         * cli/cli-cmds.c (shell_escape): Use vfork.
> 
> Index: cli/cli-cmds.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
> retrieving revision 1.22
> diff -u -p -r1.22 cli-cmds.c
> --- cli/cli-cmds.c      22 Sep 2002 22:18:41 -0000      1.22
> +++ cli/cli-cmds.c      22 Oct 2002 01:47:15 -0000
> @@ -517,7 +517,7 @@ shell_escape (char *arg, int from_tty)
>    else
>      p++;                       /* Get past '/' */
> 
> -  if ((pid = fork ()) == 0)
> +  if ((pid = vfork ()) == 0)
>      {
>        if (!arg)
>         execl (user_shell, p, 0);