This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use read_memory_unsigned_integer when reading to CORE_ADDR


I used extract_type_address to honor the comment about not causing a memory_error.

I'll check in the change from builtin_type_void_data_ptr to builtin_type_void_code_ptr.
Thanks!

Unless someone objects, I'll also change

  int ptrbytes = TARGET_PTR_BIT / TARGET_CHAR_BIT;

to

  int ptrbytes = TYPE_LENGTH (builtin_type_void_code_ptr);
Now this I like so much, I'm going to add it to the ARI as a recommendation.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]