This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: sim/mips patch: add support for more NEC VR targets


At Wed, 06 Nov 2002 19:46:07 -0500, Andrew Cagney wrote:
> >> - gen-engine.c adds the global prefix to the beginning of
> >>   ENGINE_ISSUE_(PREFIX|POSTFIX)_HOOK.  It seems MIPS is the
> >>   only back-end to define these macros, and it never adds a
> >>   prefix.  The patch adjusts igen accordingly.
> > 
> > 
> > Hmm.  I don't know igen so well.  Andrew?  What are your thoughts
> > here?
> 
> [I suspect its already been committed]
> So, how did it ever build?

Err, well, build is no problem: the code in question did #if
defined(%sENGINE_ISSUE_PREFIX_HOOK)... so it won't get in there.


> Specify two functions.  One for the mips5500 and one for the rest.  That 
> way, there isn't any reason for adding TATE_ARCHITECTURE (SD)->mach == 
> bfd_mach_mips5500.
> 
> It will also solve the default machine problem.

well:

(1) w/ separate fn, you'd need to tag _all_ of the 5500 machine insns
    w/ mips5500.  (as opposed to ISA + a few mips5500 extensions.)

(2) it doesn't actually solve the default machine problem, since you
    need to e.g. pick the right machine (possibly picking default) in
    sim_engine_run, and you need to pick the right machine (again
    possibly picking default) if doing e.g. MD cp0 register handling.
    (I've got a lot of code yet to be submitted that does the latter.)


chris


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]