This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/RFA] Move _initialize_hppa_tdep to the end of file


 > 2002-11-05  Joel Brobecker  <brobecker@gnat.com>
> > * hppa-tdep.c (_initialize_hppa_tdep): Move function body
> to end of file, to be more consistent with the pratice followed
> in other targets.

Sure.

Thanks for the little confirmation that this change was ok.


Actually multiarching a target is considered an obvious activity, so
you have the option of just post patches, instead of RFA's. For
instance see the multiarching of the h8300 (please do it with
incremental patches).

The trouble is that I still consider myself new to the GDB project,
and look forward to the many years of learning to come with great
spirit. In the meantime, I often feel more confortable after I asked
for a quick confirmation that my understanding was correct before
doing some checkins that seem too obvious to be correct.

The testsuite is a good tool, but is sometimes not enough. I could for
instance introduce a bug in a different target.
It's an accepted risk. Multi-arching takes priority over keeping things working 100%. Besides, if you're modifying HP files, the only thing you can break is HP stuff :-)

But I do reassure you, I will try to do as much as possible of the
multiarch conversion without asking for RFAs :-).
One suggestion. If you hit a problem (eg a method isn't yet multi-arch) put it to one side and work on something else.

Good luck!
Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]