This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa/i386] FP_REGNUM_P() -> i386_fp_regnum_p() et.al.
- From: Mark Kettenis <kettenis at chello dot nl>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 08 Nov 2002 13:48:12 +0100
- Subject: Re: [rfa/i386] FP_REGNUM_P() -> i386_fp_regnum_p() et.al.
- References: <3DC972D0.2010803@redhat.com>
Andrew Cagney <ac131313@redhat.com> writes:
> The attached:
>
> - converts all the macro's into functions
>
> - makes the function checks more robust - return true when both the
> regnum matches and the ISA has the register
>
> - adds a method to test for the orig_eax register (the
> I386_LINUX_ORIG_EAX_REGNUM is moved from i386-linux-tdep.h to i386-tdep.h).
>
> Ok to commit?
Looks good, but why the move of the Linux orig_eax register test to
i386-tdep.{c|h}? I'd really keep this Linux-specific quirk isolated
in a Linux-specific file.
Ok with that change. Otherwise we might need to discuss this a bit more ;-).
Mark