This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: m68k_register_virtual_type
- From: Andreas Schwab <schwab at suse dot de>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Fri, 22 Nov 2002 17:35:04 +0100
- Subject: Re: m68k_register_virtual_type
- References: <jeptsxanah.fsf@sykes.suse.de> <3DDE4E31.4010807@redhat.com>
Andrew Cagney <ac131313@redhat.com> writes:
|> Just FYI,
|>
|> > static struct type *
|> > m68k_register_virtual_type (int regnum)
|> > {
|> > - if ((unsigned) regnum >= E_FPC_REGNUM)
|> > + if (regnum == E_FPI_REGNUM)
|> > return lookup_pointer_type (builtin_type_void);
|>
|> There are now:
|> builtin_type_void_data_ptr
|> builtin_type_void_code_ptr
|> available.
Thanks, I'll change that (it's actually builtin_type_void_func_ptr).
|> > + else if ((unsigned) regnum >= E_FPC_REGNUM)
|> > + return builtin_type_int;
|>
|> builtin_type_int32 is better
|>
|> > else if ((unsigned) regnum >= FP0_REGNUM)
|> > return builtin_type_long_double;
|> > + else if (regnum == PS_REGNUM)
|> > + return builtin_type_int
|>
|> Ditto.
What about the default case for the d0-d7 registers? Should it be changed
to builtin_type_int32 as well?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."