This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [in/5.3] Fix some more build warnings
- From: David Carlton <carlton at math dot stanford dot edu>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 25 Nov 2002 14:14:34 -0800
- Subject: Re: [in/5.3] Fix some more build warnings
- References: <3DE29F26.8070603@redhat.com>
On Mon, 25 Nov 2002 17:07:34 -0500, Andrew Cagney <ac131313@redhat.com> said:
> I've checked this in to the 5.3 branch, an equivalent patch was
> committed to the mainline long ago. Just that no one noticed :-/
You might also want to grab the remote-sds.c part of this:
2002-09-30 David Carlton <carlton@math.stanford.edu>
* Makefile.in (ppc-sysv-tdep.o): Depend on gdb_string_h.
* ppc-sysv-tdep.c: #include "gdb_string.h".
* remote-sds.c (getmessage): Add semicolon after 'retry' label to
pacify GCC.
while you're at it. It fixes a warning that recent GCC's generate but
older ones don't, so you might not be seeing it. I'll include the
patch in question at the bottom of this message. I don't think it's
particularly important, but if you want to get rid of all build
warnings, maybe it's a good idea.
David Carlton
carlton@math.stanford.edu
Index: remote-sds.c
===================================================================
RCS file: /cvs/src/src/gdb/remote-sds.c,v
retrieving revision 1.20
diff -u -p -r1.20 remote-sds.c
--- remote-sds.c 10 Feb 2002 04:08:42 -0000 1.20
+++ remote-sds.c 30 Sep 2002 18:45:17 -0000
@@ -978,6 +978,7 @@ getmessage (unsigned char *buf, int fore
/* Try the whole thing again. */
retry:
/* need to do something here */
+ ;
}
/* We have tried hard enough, and just can't receive the packet. Give up. */