This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: gdb/769 - segv fault on "info shared" on GDB 5.2.1 HPUX64 11.00


I was not familiar with how gdb called errors, so I just looked at similar code 
from that source file. If what I used was not the correct method then by all 
means change the patch, or point me to the definition of error() so I can change 
it appropriately.

 - Josh Martin
 
> Date: Mon, 25 Nov 2002 16:08:20 -0700
> From: Kevin Buettner <kevinb@redhat.com>
> To: Josh Martin <Josh.Martin@abq.sc.philips.com>, 
gdb-patches@sources.redhat.com
> Subject: Re: [PATCH]: gdb/769 - segv fault on "info shared" on GDB 5.2.1 
HPUX64 11.00
> MIME-Version: 1.0
> 
> On Oct 9,  5:42pm, Josh Martin wrote:
> 
> > 2002-09-28  Josh Martin  <timeslice@iname.com>
> >  
> > 	* solib.c (info_sharedlibrary_command): Added catch for potential
> > 	dereference of NULL pointer (current_target_so_ops).
> > 	Fix PR gdb/769.
> 
> Josh,
> 
> Your patch looks reasonable.  I think I'd prefer to see a call to error()
> instead of printf_unfiltered() though:
> 
> > > +      printf_unfiltered("Shared library info is not yet implemented on 
this "
> > > +			"platform\n");
> 
> Sorry for taking so long on this.
> 
> Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]