Re: [RFA/testsuite] Shorten the maint.exp symbols tests

[David Carlton <carlton at math dot stanford dot edu>]

On Wed, 4 Dec 2002 17:20:32 -0500, Daniel Jacobowitz <drow@mvista.com> said:
> On Wed, Dec 04, 2002 at 01:52:04PM -0800, David Carlton wrote:

>> The maint.exp changes in question cause testsuite failures on my
>> system for 'maint print symbols' and 'maint print psymbols'.  I've
>> played around with it a bit; it seems to me that if I do
>> 
>> (gdb) maint print symbols symbols_output ./gdb.base/break.c
>> 
>> (which is what maint.exp does in my situation) then I get an empty
>> file symbols_output, whereas if I just do
>> 
>> (gdb) maint print symbols symbols_output gdb.base/break.c
>> 
>> then I get the correct symbols_output file.  Here, I'm running GDB
>> from within the testsuite directory; I don't use a separate build
>> directory when configuring GDB, which might or might not make a
>> difference.

> Blech!  I'm not sure what to do about this.  Somehow we'd need to
> figure out how the file was compiled - is the logic to decide this
> in gdb_compile?  Does the compiler clean it up on its own?  Maybe if
> we pass an explicit srcdir to gdb_compile we can get consistent
> results here.

It's certainly not obvious to me how to fix the testsuite in this
situation.  After all, gdb_compile gets passed
${srcdir}/${subdir}/${srcfile}, which is exactly what you look for in
your maint print symbols call ("./gdb.base/break.c" in my example), so
I have a hard time imagining what a simple fix might be to the
testsuite that would allow it to guess the right thing (barring some
fragile hack like checking if $srcdir is ".").

> Or maybe we should make 'maint print symbols symbols_output break.c'
> match all files ending in break.c.  That's much less fragile.  What
> do you think?

If it's easy to implement, one possibility would be for maint print
symbols to turn its argument into an absolute path (in a fairly
canonical form, so without ".", "..", and possibly without symbol
links) and to do the same thing for the filenames associated to the
symtabs before comparing those filenames to its argument.

David Carlton
carlton@math.stanford.edu