This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Replace complain() with complaint()

On Dec 13,  4:49pm, Andrew Cagney wrote:

> > Okay, now I see a -Wformat warning.  Fortunately, buildsym.c was the only
> > file affected.  Below are the diffs that I propose using for that file.
> > (These take the place of the buildsym.c diffs that I previously posted.)
> > The ChangeLog entries remain the same.
> 
> Ok.  Out of interest, how many other problems did the first pass find?

Perhaps a dozen.  There were several cases of int formats with long
arguments.  Also, there were a number of cases in which complain() was
being called with an incorrect number of arguments (for the format
string).

So the new interface did indeed catch a number of problems.

Kevin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]