This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] improved error message


Andrew Cagney wrote:
There are like five places in thread-db.c that all give the same
error message.  This just adds the function name, so you have a
chance of figuring out where the error occurred.

2002-12-13  Michael Snyder  <msnyder@to-limbo.toronto.redhat.com>

    * thread-db.c (thread_from_lwp): Uniquify error msg.
    (lwp_from_thread): Ditto.
    (check_event): Ditto.
    (find_new_threads_callback): Ditto.
    (thread_db_pid_to_str): Ditto.

Er, this looks wrong. A normal user visible error message should not include references to internal function names. Can you either reword the messages or, perhaphs, add a debug mode that displys this additional information?
Why not? Having function names in error messages helps a lot in getting useful bugreports from users.

Michal Ludvig
--
* SuSE CR, s.r.o * mludvig@suse.cz
* (+420) 296.545.373 * http://www.suse.cz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]