This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fork event updates, part the tenth


Right now, there are four calls to bpstat_stop_status in infrun.c.  Three of
them are for catchpoints; right now, catchpoints should not be affected by
DECR_PC_AFTER_BREAK, because they aren't breakpoints.  Hopefully
DECR_PC_AFTER_BREAK will be gone from this code if anyone ever has a target
where they _are_ breakpoints.

So, since a catchpoint is not a software breakpoint, we can just pass "1"
for NOT_A_SW_BREAKPOINT.  This prevents an incorrect PC decrement on
i386-linux with the upcoming fork catchpoint patches.  Committed.
Er, where is the fire? Nothing involving decr pc after break is obvious. I think here you should at least be seeking a second opinion.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]