This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Recent MI patches broke the testsuite


On Mon, Dec 16, 2002 at 01:04:42PM -0500, J. Johnston wrote:
> My bad.  :(  The new mi-basics.exp testcase is my usual sanity test
> for this change.  It was updated and in fact works fine as it is expecting
> the new behavior.

Not in my checkout:

202-environment-directory ../../../src/gdb/testsuite/gdb.mi
202^done,source-path="/opt/src/binutils/x86-as/gdb/testsuite/../../../src/gdb/testsuite/gdb.mi:$cdir:$cwd"
(gdb) 
FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation

Oh, that's a different problem.  Using ${srcdir} that way doesn't work
if configured with a relative srcdir.  Just an extra wildcard will fix
it for now.

(i.e. I built this tree with ../../../src/configure)

> I did not look at the correct gdb.log for the full mi testsuite.
> As you have noted, the lib/mi-support.exp routine mi_reinitialize_dir
> is using -environment-directory and is expecting the old output.
> 
> I have a patch for lib/mi=support.exp to handle the new syntax which I have
> included.  Since I require approval for patches I will revert the
> original patch and resubmit with the added change unless Elena says
> otherwise.

Thank you very much for following up on this!  The testsuite patch
looks reasonable to my inexperienced eye.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]