This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch/rfc] KFAIL gdb.c++/annota2.exp watch triggered on a.x


On Fri, Jan 03, 2003 at 01:35:59PM -0800, David Carlton wrote:
> Here's a patch to KFAIL the test "watch triggered on a.x" in
> gdb.c++/annota2.exp, corresponding to PR breakpoints/38.  The test
> fails consistently on all the configurations that Michael tests.
> 
> This is an obvious candidate for KFAILing.  My only question is when
> it should currently be expected to pass.  The PR indicates that it
> might pass on some platforms; on the other hand, it fails reliably
> on i686-pc-linux-gnu.  So what I did was change the two existing
> instances of
> 
>   { pass "watch triggered on a.x" }
> 
> to
> 
>   { setup_kfail "gdb/38" "i686*-*-*"
>     pass "watch triggered on a.x" }
> 
> but I made the new KFAIL case unconditional.  That seemed to be the
> safest thing: that way, any FAIL or KPASS message is interesting.

May I recommend at the least "i?86"?  Also, I really don't see the
point of the kpass's; before doing this, you need to establish if those
patterns are acceptable results; if so, they are passes, period.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]