This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[commit] frame_obstack_alloc() -> frame_obstack_zalloc()
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Thu, 09 Jan 2003 13:54:30 -0500
- Subject: [commit] frame_obstack_alloc() -> frame_obstack_zalloc()
Cosmetic change, ..._zalloc() returns zeroed memory.
committed,
Andrew
2003-01-09 Andrew Cagney <ac131313@redhat.com>
* frame.h (frame_obstack_zalloc): Replace frame_obstack_alloc.
Update comments.
* frame.c (frame_obstack_zalloc): Replace frame_obstack_alloc.
(frame_saved_regs_zalloc): Update.
(frame_saved_regs_register_unwind): Update.
(create_new_frame): Update.
(get_prev_frame): Update.
(frame_extra_info_zalloc): Update.
(deprecated_get_frame_saved_regs): Update.
* dwarf2cfi.c (cfi_init_extra_frame_info): Update.
* cris-tdep.c: Update comment.
Index: cris-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/cris-tdep.c,v
retrieving revision 1.43
diff -u -r1.43 cris-tdep.c
--- cris-tdep.c 8 Jan 2003 19:45:22 -0000 1.43
+++ cris-tdep.c 9 Jan 2003 18:47:42 -0000
@@ -1148,8 +1148,7 @@
/* See frame.h. Determines the address of all registers in the current stack
frame storing each in frame->saved_regs. Space for frame->saved_regs shall
- be allocated by FRAME_INIT_SAVED_REGS using either frame_saved_regs_zalloc
- or frame_obstack_alloc. */
+ be allocated by FRAME_INIT_SAVED_REGS using frame_saved_regs_zalloc. */
void
cris_frame_init_saved_regs (struct frame_info *fi)
Index: dwarf2cfi.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2cfi.c,v
retrieving revision 1.26
diff -u -r1.26 dwarf2cfi.c
--- dwarf2cfi.c 8 Jan 2003 15:56:36 -0000 1.26
+++ dwarf2cfi.c 9 Jan 2003 18:47:42 -0000
@@ -1770,9 +1770,9 @@
unwind_tmp_obstack_init ();
fs = frame_state_alloc ();
- deprecated_set_frame_context (fi, frame_obstack_alloc (sizeof (struct context)));
+ deprecated_set_frame_context (fi, frame_obstack_zalloc (sizeof (struct context)));
UNWIND_CONTEXT (fi)->reg =
- frame_obstack_alloc (sizeof (struct context_reg) * NUM_REGS);
+ frame_obstack_zalloc (sizeof (struct context_reg) * NUM_REGS);
memset (UNWIND_CONTEXT (fi)->reg, 0,
sizeof (struct context_reg) * NUM_REGS);
Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.55
diff -u -r1.55 frame.c
--- frame.c 7 Jan 2003 22:53:09 -0000 1.55
+++ frame.c 9 Jan 2003 18:47:43 -0000
@@ -456,17 +456,18 @@
static struct obstack frame_cache_obstack;
void *
-frame_obstack_alloc (unsigned long size)
+frame_obstack_zalloc (unsigned long size)
{
- return obstack_alloc (&frame_cache_obstack, size);
+ void *data = obstack_alloc (&frame_cache_obstack, size);
+ memset (data, 0, size);
+ return data;
}
CORE_ADDR *
frame_saved_regs_zalloc (struct frame_info *fi)
{
fi->saved_regs = (CORE_ADDR *)
- frame_obstack_alloc (SIZEOF_FRAME_SAVED_REGS);
- memset (fi->saved_regs, 0, SIZEOF_FRAME_SAVED_REGS);
+ frame_obstack_zalloc (SIZEOF_FRAME_SAVED_REGS);
return fi->saved_regs;
}
@@ -605,14 +606,13 @@
{
int sizeof_cache = ((NUM_REGS + NUM_PSEUDO_REGS)
* sizeof (void *));
- regs = frame_obstack_alloc (sizeof_cache);
- memset (regs, 0, sizeof_cache);
+ regs = frame_obstack_zalloc (sizeof_cache);
(*cache) = regs;
}
if (regs[regnum] == NULL)
{
regs[regnum]
- = frame_obstack_alloc (REGISTER_RAW_SIZE (regnum));
+ = frame_obstack_zalloc (REGISTER_RAW_SIZE (regnum));
read_memory (frame->saved_regs[regnum], regs[regnum],
REGISTER_RAW_SIZE (regnum));
}
@@ -847,12 +847,7 @@
struct frame_info *fi;
enum frame_type type;
- fi = (struct frame_info *)
- obstack_alloc (&frame_cache_obstack,
- sizeof (struct frame_info));
-
- /* Zero all fields by default. */
- memset (fi, 0, sizeof (struct frame_info));
+ fi = frame_obstack_zalloc (sizeof (struct frame_info));
fi->frame = addr;
fi->pc = pc;
@@ -1018,10 +1013,7 @@
return 0;
/* Create an initially zero previous frame. */
- prev = (struct frame_info *)
- obstack_alloc (&frame_cache_obstack,
- sizeof (struct frame_info));
- memset (prev, 0, sizeof (struct frame_info));
+ prev = frame_obstack_zalloc (sizeof (struct frame_info));
/* Link it in. */
next_frame->prev = prev;
@@ -1250,7 +1242,7 @@
if (frame->saved_regs == NULL)
{
frame->saved_regs = (CORE_ADDR *)
- frame_obstack_alloc (SIZEOF_FRAME_SAVED_REGS);
+ frame_obstack_zalloc (SIZEOF_FRAME_SAVED_REGS);
}
if (saved_regs_addr == NULL)
{
@@ -1275,8 +1267,7 @@
struct frame_extra_info *
frame_extra_info_zalloc (struct frame_info *fi, long size)
{
- fi->extra_info = frame_obstack_alloc (size);
- memset (fi->extra_info, 0, size);
+ fi->extra_info = frame_obstack_zalloc (size);
return fi->extra_info;
}
Index: frame.h
===================================================================
RCS file: /cvs/src/src/gdb/frame.h,v
retrieving revision 1.58
diff -u -r1.58 frame.h
--- frame.h 7 Jan 2003 22:53:09 -0000 1.58
+++ frame.h 9 Jan 2003 18:47:43 -0000
@@ -310,7 +310,7 @@
UNWIND_CACHE is provided as mechanism for implementing a per-frame
local cache. It's initial value being NULL. Memory for that cache
- should be allocated using frame_obstack_alloc().
+ should be allocated using frame_obstack_zalloc().
Register window architectures (eg SPARC) should note that REGNUM
identifies the register for the previous frame. For instance, a
@@ -413,7 +413,7 @@
/* Anything extra for this structure that may have been defined
in the machine dependent files. */
- /* Allocated by frame_obstack_alloc () which is called /
+ /* Allocated by frame_extra_info_zalloc () which is called /
initialized by INIT_EXTRA_FRAME_INFO */
struct frame_extra_info *extra_info;
@@ -472,7 +472,11 @@
#define SIZEOF_FRAME_SAVED_REGS \
(sizeof (CORE_ADDR) * (NUM_REGS+NUM_PSEUDO_REGS))
-extern void *frame_obstack_alloc (unsigned long size);
+/* Allocate zero initialized memory from the frame cache obstack.
+ Appendices to the frame info (such as the unwind cache) should
+ allocate memory using this method. */
+
+extern void *frame_obstack_zalloc (unsigned long size);
/* If FRAME_CHAIN_VALID returns zero it means that the given frame
is the outermost one and has no caller. */