This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch] linespec.c: rename 's' to 'file_symtab'
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: David Carlton <carlton at math dot stanford dot edu>
- Cc: gdb-patches at sources dot redhat dot com, Elena Zannoni <ezannoni at redhat dot com>
- Date: Sun, 12 Jan 2003 13:31:08 -0500
- Subject: Re: [patch] linespec.c: rename 's' to 'file_symtab'
- References: <ro1r8bkbimf.fsf@jackfruit.Stanford.EDU>
David Carlton writes:
> This patch renames the variable 's' to 'file_symtab' in decode_line_1,
> as well as in the functions to which decode_line_1 passes it as an
> argument.
>
> Tested on i686-pc-linux-gnu/GCC 3.1/DWARF-2. Committed as obvious.
>
> And yes, Elena's probably annoyed at me right now for committing a
> 200-line patch as obvious, despite her request to keep them short. :-)
> But it really is obvious: if you look at the patch, every single line
> just changes 's' to 'file_symtab', and if I missed any places to
> change it, the compiler would have been happy to inform me. (Though I
> did run the testsuite as well, because I'm anal.) Don't worry: my
> future 'obvious' patches will be much shorter, this one just happens
> to rename a variable that occurs all over the place.
>
> David Carlton
> carlton@math.stanford.edu
>
Nah, you won't incur into Elena's wrath this time. :-)
Elena