This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] linespec.c: rename 's' to 'file_symtab'


David Carlton writes:
 > This patch renames the variable 's' to 'file_symtab' in decode_line_1,
 > as well as in the functions to which decode_line_1 passes it as an
 > argument.
 > 
 > Tested on i686-pc-linux-gnu/GCC 3.1/DWARF-2.  Committed as obvious.
 > 
 > And yes, Elena's probably annoyed at me right now for committing a
 > 200-line patch as obvious, despite her request to keep them short. :-)
 > But it really is obvious: if you look at the patch, every single line
 > just changes 's' to 'file_symtab', and if I missed any places to
 > change it, the compiler would have been happy to inform me.  (Though I
 > did run the testsuite as well, because I'm anal.)  Don't worry: my
 > future 'obvious' patches will be much shorter, this one just happens
 > to rename a variable that occurs all over the place.
 > 
 > David Carlton
 > carlton@math.stanford.edu
 > 


Nah, you won't incur into Elena's wrath this time. :-)

Elena


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]