This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: PATCH/testsuite: Remove extra xfails from constvars.exp
- From: Michael Elizabeth Chastain <mec at shout dot net>
- To: drow at mvista dot com, gdb-patches at sources dot redhat dot com
- Date: Tue, 14 Jan 2003 11:48:48 -0600
- Subject: Re: PATCH/testsuite: Remove extra xfails from constvars.exp
Looks good to me.
> Evenetually I want to update this fail to only XFAIL on gcc2.x + stabs
> (and maybe early 3.x + stabs), since gcc 3.0.4 + stabs and later get
> the consts correct. That's for another day. Checked in, obvious.
It's fine with me to ignore gcc 3.0.X and even gcc 3.1.X. My position
is that gdb can require that anyone using a gcc 3.X to have gcc 3.2
or later (that is, two stable releases back). I can see relaxing this
to gcc 3.1, but if we start supporting gcc 3.0.X, that's a lot of
work for minimal benefit.
It's easy to tell gcc v2 from gcc v3 in local_compiler_xfail_check.
The gcc_compiled variable is not just a boolean. It's the major
version number of gcc. So I think this one-liner would do it:
- if {$gcc_compiled} then {
+ if {$gcc_compiled == 2} then {
Michael C