This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Andrew, I finally had a look at this problem. > >I'll try to have a look today (thanks for this notice!). > > I'd better explain why I think I broke it :-/ I believe the old code > had the sequence: > > tm-hppa64.h: > #include "tm-hppa.h" > tm-hppa.h: > #define CALL_DUMMY_LOCATION ON_STACK > #undef CALL_DUMMY_LOCATION I believe you are right. I did a bit of archeology, but could not find the purpose of this undef. Before you added the '#define CALL_DUMMY_LOCATION ON_STACK' when you changed the default value for CALL_DUMMY_LOCATION, there was no such defined in tm-hppa.h... So the undef was useless, and now seems to cause some breakage on hppa64. Short of understanding completely the issues at hand, I simply ran the testsuite with and without the #undef, and found that that results are sensibly better without (ie, to my relief, you guess right about hppa64). I have the following change ready: 2003-01-28 J. Brobecker <brobecker@gnat.com> * config/pa/tm-hppa64.h (CALL_DUMMY_LOCATION): Remove #undef causing some regressions due to a change in the default value for this macro. -- Joel
Attachment:
tm-hppa64.h
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |