This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch to add QNX NTO i386 support


/* After a watchpoint trap, the PC points to the instruction after
>    the one that caused the trap.  Therefore we don't need to step over
it.

>    But we do need to reset the status register to avoid another trap.
*/

> #define HAVE_CONTINUABLE_WATCHPOINT

Hmm, this poses an interesting problem.  The other i386 targets have
this in their nm.h file, since they consider hardware watchpoints as a
native-only feature.  However, this isn't necessarily right since we
might support hardware breakpoints via the remote protocol.  If you
can live with the native-only approach, please move this to your nm.h
file.  Otherwise we might need to multi-arch this definition.

Okay, file that under TODO along with the solib stuff.  We have hardware
breakpoints on all our remote targets that support them.
Just FYI, this needs to be added to the target vector (target.h) and not the architecture vector.

For examples, see STOPPED_BY_WATCHPOINT et.al. A bit of manipulation of the existing nm-*.h files will be needed - have them define the value as 1.

Can you please submit a separate patch that does just this.

Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]