This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Testsuite: fix attach.exp test for FreeBSD 5.0
- From: Michael Elizabeth Chastain <mec at shout dot net>
- To: gdb-patches at sources dot redhat dot com, kettenis at chello dot nl
- Date: Sat, 15 Feb 2003 10:09:03 -0600
- Subject: Re: [RFA] Testsuite: fix attach.exp test for FreeBSD 5.0
It looks good to me. I have two issues:
. add '2003' to the copyright years.
. please say what system(s) you tested it on.
I proofread it and ran it through my test bed with no problems
(native i686-pc-linux-gnu, red hat 8.0, glibc 2.2.93-5,
gcc v2 and v3, dwarf-2 and stabs+).
After those two issues, I would recommend this patch for approval
(I can only recommend, I can't approve).
Michael C
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* gdb.base/attach.exp: When trying to attach to a nonexistent
process, make it possible to specify the PID based on the target.