This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[rfa] test suite: remove setup_xfail_format "DWARF 1"


This patch removes the remaining calls to setup_xfail_format "DWARF 1".

As before, this is benign for two reasons:

(1) This particular setup_xfail_format does not even work.  When I run
    this test script with -gdwarf or -gdwarf+, the test script gets
    confused and runs 'info source' on the C run time rather than
    'main', coming up with a value of 'DWARF 2'.  This is true for
    every get_debug_format call in the whole test suite.

(2) When I run the test suite with -gdwarf or -gdwarf+, I get 40+ ERRORs
    and 3400+ FAILs.  So killing all the setup_xfail_formats for DWARF 1
    is not going to make any difference to any poor soul who is trying
    to run the test suite with -gdwarf or -gdwarf+.

Testing: tested on native i686-pc-linux-gnu with gcc v2 and v3,
with -gdwarf, -gdwarf+, -gdwarf-2, and -gstabs+.  All the results
were identical, even with -gdwarf and -gdwarf+.

OK to commit?

(When I see 'Two Towers' I am going to cheer for the orcs,
 because they enjoy killing dwarf's, just like me!)

Michael C

2003-02-15  Michael Chastain  <mec@shout.net>

	* gdb.base/list.exp: Remove setup_xfail_format for DWARF 1.
	* gdb.base/ptype.exp: Likewise.

Index: list.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/list.exp,v
retrieving revision 1.8
diff -u -r1.8 list.exp
--- list.exp	15 Feb 2003 18:32:45 -0000	1.8
+++ list.exp	15 Feb 2003 18:47:21 -0000
@@ -164,11 +164,9 @@
 proc test_list_include_file {} {
     global gdb_prompt
 
-    setup_xfail_format "DWARF 1"
     setup_xfail_format "COFF"
     gdb_test "list list0.h:1" "1\[ \t\]+/\[*\]+ An include file .*10\[ \t\]+bar \\(x\\+\\+\\);" "list line 1 in include file"
 
-    setup_xfail_format "DWARF 1"
     setup_xfail_format "COFF"
     gdb_test "list list0.h:100" "Line number 95 out of range; .*list0.h has 3\[67\] lines." "list message for lines past EOF"
 }
@@ -239,7 +237,6 @@
     # Ultrix gdb is the second case, still correct.
     # SunPRO cc is the third case.
     setup_xfail "powerpc-*-*"
-    setup_xfail_format "DWARF 1"
     gdb_test "list foo" "(3\[ \t\]+.*12\[ \t\]+bar \[(\]+.*\[)\]+;|2\[ \t\]+including file.*11\[ \t\]+bar \[(\]+.*\[)\]+;|1\[ \t\]+/. An include file.*10\[ \t\]+bar \[(\]+.*\[)\]+;)" "list function in include file"
 }
 
@@ -427,7 +424,6 @@
     # SunPRO cc is the third case.
     setup_xfail "rs6000-*-*" 1804
     setup_xfail "powerpc-*-*" 1804
-    setup_xfail_format "DWARF 1"
     setup_xfail_format "COFF"
     send_gdb "list list0.h:foo\n"
     gdb_expect {
@@ -496,7 +492,6 @@
 
     gdb_test "list foobar.c:main" "No source file named foobar.c.|Location not found" "list filename:function; nonexistant file"
 
-    setup_xfail_format "DWARF 1"
     gdb_test "list list0.h:foobar" "Function \"foobar\" not defined.|Location not found" "list filename:function; nonexistant function"
 
 }
Index: ptype.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/ptype.exp,v
retrieving revision 1.6
diff -u -r1.6 ptype.exp
--- ptype.exp	15 Feb 2003 18:32:45 -0000	1.6
+++ ptype.exp	15 Feb 2003 19:01:41 -0000
@@ -1,5 +1,5 @@
 # Copyright 1988, 1990, 1991, 1992, 1994, 1995, 1996, 1997, 1999,
-# 2000, 2002 Free Software Foundation, Inc.
+# 2000, 2002, 2003 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -137,7 +137,6 @@
 # For get_debug_format to do its job, we need to have a current source file.
 gdb_test "list main" ""
 get_debug_format
-setup_xfail_format "DWARF 1"
 gdb_test "whatis v_boolean" "type = (enum |)boolean" \
   "whatis unnamed typedef'd enum (compiler bug in IBM's xlc)"
 
@@ -370,7 +369,6 @@
 #
 
 if {!$gcc_compiled} then { setup_xfail "rs6000-*-*" "i*86-*-sysv4*" }
-setup_xfail_format "DWARF 1"
 if {$hp_aCC_compiler} {setup_xfail "hppa*-*-*"}
 gdb_test "ptype t_char_array" "type = (|unsigned )char \\\[0?\\\]"
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]