This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfa] revert my previous search_symbols change, add comment


On Thu, 20 Feb 2003 15:47:20 -0500, Elena Zannoni <ezannoni at redhat dot com> said:
> David Carlton writes:

>> In my patch from 2002-12-23, I changed some code in search_symbols
>> from a call to lookup_symbol to a call to lookup_symbol_aux_minsyms.
>> At that time, I didn't understand exactly what
>> lookup_symbol_aux_minsyms did; now that I understand that function
>> better, I don't think that change was a good idea.
>> 
>> So this patch reverts that change.  At Andrew's suggestion, I've added
>> a comment as well, saying what I'd really like to replace the call to
>> lookup_symbol with.

> OK

Thanks; I'll commit it in a sec.

>> In my next patch, I'll change lookup_symbol_aux_minsyms to actually do
>> something correct (now that Daniel has been kind enough to demangle
>> partial symbols for me), but I wanted to get this part of the change
>> out of the way first.
>> 

> Question, where does the other patch I just replied to stand wrt to this?
> Should we forget about the old patch? 

Crossing e-mails; by now, you've gotten the e-mail where I explain
that, or will in a sec.

David Carlton
carlton at math dot stanford dot edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]