This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA/symtab: Let search_symbols find exact matches


On Thu, Feb 20, 2003 at 02:41:18PM -0800, David Carlton wrote:
> On Mon, 10 Feb 2003 11:01:07 -0500, Daniel Jacobowitz <drow at mvista dot com> said:
> 
> > This patch renames search_symbols to search_symbols_aux, and lets it take an
> > argument that specified regex or exact (well, strcmp_iw) matching.  Then
> > search_symbols becomes a wrapper.
> 
> > The new function is used by make_symbol_overload_list, which shaves 50% time
> > off of some tests in the C++ directory if your system libc has debugging
> > symbols; it removes the bogusity where all psymtabs were converted to
> > symtabs during overload resolution.  Whew.  This cuts memory for
> > namespace.exp from 70MB to 7MB, allowing some of my hardware to actually run
> > the test without crashing.
> 
> Here's take two on my comments on this.  First, I should say that I
> totally agree that the aforementioned bogusity in
> make_symbol_overload_list should go; as discussed in
> <http://sources.redhat.com/ml/gdb-patches/2003-02/msg00261.html>,
> though, there are ways of doing that that involve much less drastic
> changes.

Good enough for me.  This patch is withdrawn.  David, are you convinced
that lookup_partial_symbol is close enough to what we want for the
patch above?  You expressed some concerns earlier.  If you're happy
with it, I'll approve the patch.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]