This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Unreviewed PATCH: SH Simulator - MAC.L implementation and MAC.W correction
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: gdb-patches at sources dot redhat dot com
- Cc: Jorn Rennecke <joern dot rennecke at superh dot com>,Elena Zannoni <ezannoni at redhat dot com>
- Date: Tue, 25 Feb 2003 08:53:02 -0500
- Subject: Re: Unreviewed PATCH: SH Simulator - MAC.L implementation and MAC.W correction
- References: <69595093233BB547BB70CF5E492B63F2DA69F7@sohm.kpit.com>
On Tue, Feb 25, 2003 at 05:32:22PM +0530, Shrinivas Atre wrote:
> Hi,
>
> Could someone please review the following patch for the SH-simulator?
>
> http://sources.redhat.com/ml/gdb/2002-11/msg00365.html
Shrinivas,
The patch looks good to me; I'm not all that fond of the xor games for
the sign bit but the SH simulator already uses that construct so it's
OK.
However, I'm not very familiar with SH, I don't know the algorithm in
question, and the SH sim doesn't have a specific maintainer. Elena,
you're GDB's SH maintainer; do you have any comments on this patch?
Or J"orn?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer