This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Dwarf2CFI fix
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Michal Ludvig <mludvig at suse dot cz>
- Cc: GDB Patches <gdb-patches at sources dot redhat dot com>
- Date: Wed, 26 Feb 2003 12:25:53 -0500
- Subject: Re: [RFA] Dwarf2CFI fix
- References: <3E5CF5F5.10300@suse.cz>
On Wed, Feb 26, 2003 at 06:14:29PM +0100, Michal Ludvig wrote:
> Hi all,
> my code in dwarf2cfi.c assumed that CIE and FDE entries in .eh_frame are
> always in the chain CIE, FDE, FDE, ..., CIE, FDE, ...
> where every FDE refers to the precedent CIE. Unfortunately this is not
> alway the case. Linker (?) sometimes optimizes things in a way that the
> assumption isn't true anymore. This patch addresses the problem.
>
> OK to commit? Head and 5.3?
> 2003-02-26 Michal Ludvig <mludvig at suse dot cz>
>
> * dwarf2cfi.c (parse_frame_info): It's not true that FDEs
> always refer to the last CIE. We must deal with such a
> situation.
> * dwarf2cfi.h (
Either you're missing a bit of a patch or you're missing a bit of a
changelog. And there's no changelog entry for struct eh_frame either.
> diff -upr gdb-upto-08/dwarf2cfi.c gdb/dwarf2cfi.c
> --- gdb-upto-08/dwarf2cfi.c 2003-02-26 10:20:02.000000000 +0100
> +++ gdb/dwarf2cfi.c 2003-02-26 17:17:30.000000000 +0100
> @@ -50,6 +50,10 @@ struct cie_unit
> char *data;
> unsigned int data_length;
>
> + /* This field is 1 for CIE from .eh_frame
> + and 0 for one from .debug_frame. */
Formatting: don't wrap that early, and two spaces after a period.
The patch itself looks OK.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer