This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [patch/rfc] Add a sentinel frame
- From: Michal Ludvig <mludvig at suse dot cz>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: GDB Patches <gdb-patches at sources dot redhat dot com>
- Date: Wed, 05 Mar 2003 18:38:13 +0100
- Subject: Re: [patch/rfc] Add a sentinel frame
- Organization: SuSE CR
- References: <3E305670.3020700@redhat.com> <3E48378E.6090007@suse.cz> <3E492953.8010001@redhat.com> <3E52173B.1030800@suse.cz> <3E538770.6070209@redhat.com> <3E5B98D8.3030002@suse.cz> <3E5BAB7D.8090801@redhat.com> <3E5BD957.9010605@suse.cz> <3E5BDCBD.2030205@redhat.com> <3E5C7512.2080207@suse.cz> <3E5E58FC.3080704@redhat.com> <3E5F5DEE.3030505@suse.cz> <3E5F8559.1020708@redhat.com>
Andrew Cagney wrote:
Well, to fix this specific bug I think you'd just need to implement:
save_dummy_frame_tos()
unwind_dummy_id() (see uncommitted patch I posted).
And ensure that the top-of-stack value saved by save_dummy_frame_tos()
matches the id.base value returned by unwind_dummy_id().
I added this:
Index: dummy-frame.c
===================================================================
RCS file: /cvs/src/src/gdb/dummy-frame.c,v
retrieving revision 1.10
diff -u -p -r1.10 dummy-frame.c
--- dummy-frame.c 19 Jan 2003 17:39:16 -0000 1.10
+++ dummy-frame.c 5 Mar 2003 17:30:56 -0000
@@ -246,6 +246,17 @@ generic_save_dummy_frame_tos (CORE_ADDR
dummy_frame_stack->top = sp;
}
+struct frame_id
+generic_unwind_dummy_id (struct gdbarch *gdbarch, struct frame_info *frame)
+{
+ static struct frame_id id;
+
+ id.base = dummy_frame_stack->top;
+ id.pc = frame->pc;
+
+ return id;
+}
+
/* Record the upper/lower bounds on the address of the call dummy. */
void
and registered to the target:
set_gdbarch_save_dummy_frame_tos (gdbarch,generic_save_dummy_frame_tos);
set_gdbarch_unwind_dummy_id (gdbarch, generic_unwind_dummy_id);
I don't know if everything works as it should, but at least simple
(gdb) print func(123)
doesn't segfault and surprisingly even returns a result!
Does the above look correct to you?
Michal Ludvig
--
* SuSE CR, s.r.o * mludvig at suse dot cz
* (+420) 296.545.373 * http://www.suse.cz