This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA/RFC] disable-nls if msgfmt could not be found


Hello, 

I hope I am sending this to the right list...

Some users building GDB on systems where msgfmt is not available were
blocked when the build failed (in bfd, and probably another subdir
that I can't remember). See
http://sources.redhat.com/ml/gdb/2003-02/msg00310.html.

Instead of adding the checks in each subdir, I thought that it might be
better to do the check for msgfmt in the toplevel configure, and pass
--disable-nls to the subdir configure commands if not found. The
following patches tries to do this, and has been tested on a hpux box
where msgfmt is missing, and on a linux machine where msgfmt was
available.

Ideally, we want to do the check for msgfmt only if --disable-nls was
not already specified. However, the only consequence of not checking
for the presence of --disable-nls is that we might have more than one
--disable/enable-nls switches on the subdir configure commands. I
think it will be ok, since I've placed the --disable-nls at the end
so it should overide the user's switch. An AC_MSG_WARN may also have
been nice, but I decided against it because seeing a warning even
when the user has specified --disable-nls would seem strange...

Would the following change be acceptable for inclusion?

2003-03-17  J. Brobecker  <brobecker at gnat dot com>

        * configure.in: Add check for msgfmt, configure subdir with
        --disable-nls if not found.
        * configure: Regenerate.

-- 
Joel

Attachment: configure.in.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]