This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Adding -file-list-exec-source-file command to GDB/MI


On Mon, Mar 31, 2003 at 12:38:13AM -0500, Andrew Cagney wrote:

>This change essentially adds the command -file-list-exec-source-file to
>the mi commands.
>
>* mi-cmd-file.c:    Added file to implement mi file commands.
>* mi-cmds.c:        Added -file-list-exec-source-file command.
>* mi-cmds.h:        Added -file-list-exec-source-file to proto list.
>* doc/gdb.texinfo:  Document -file-list-exec-source-file.




>* mi-file.exp: Added testcase to test -file-list-exec-source-file.


I've attached a slightly tweaked version. It was checking for the path to the executable instead of the source file (separate build / config directories is the norm) (I'm also not sure what would happen if the configure contained a relative path but worry about that when someone notices :-)


I am noticing this now. The variable
set abs_srcfile [string_to_regexp ${srcdir}/${subdir}/${srcfile}]
has the value ("\./gdb\.mi/basics\.c") when I run the testcase.
This is why I made it check for the path to the executable in the first
place.


What do you think we should do here? I have no idea.

Unfortunatly ditto. A pattern like:


"/.*/${srcfile}"

would at least check that it has gained a leading slash.

Expect/Dejagnu must have a realpath equivalent. Unfortunatly, I don't know what it is.

I like fullname because it is used already in symtab.h

  /* Full name of file as found by searching the source path.
     NULL if not yet known.  */

char *fullname;

sold.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]