This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5]




Daniel Jacobowitz wrote:
On Thu, Mar 20, 2003 at 05:13:40PM -0500, Andrew Cagney wrote:


Would it be possible to make the cplus_demangle() method part of the language vector? That way code like the patch below could be reduced to:


    /* Return demangled language symbol, or NULL.  */
    language_demangle (current_language, arg);

This would in turn allow Adam to just add an equivalent objc_demangle() method to the objc language vector, and hence eliminate the need to always link in objc-lang.c.

As well as then? The places where objc is adding calls to the demangler the language is known.


My gut reaction is that it's just clutter until we decide how to solve the problem of not knowing demanglings. But it'll do for now. I'd like a comment along the lines of:

/* FIXME: sometimes the demangler is invoked when we don't know the
   language, so we can't use this everywhere.  */


Here's my crack at doing this

Looks right to me. Daniel, see any C++ problems?


2003-03-30 Adam Fedor <fedor at gnu dot org>

* Makefile.in (c_lang.c, jv_lang.c): Add $(demangle_h).

I think you ment c-lang.o, jv-lang.o.


Andrew



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]