This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5]


On 31 Mar 2003 14:53:21 -0800, David Carlton <carlton at math dot stanford dot edu> said:
> On Sun, 30 Mar 2003 19:23:08 -0700, Adam Fedor <fedor at doc dot com> said:

>> Here's my crack at doing [language-specific demangling].

> This patch bothers me: it doesn't handle Java cleanly, and I'm not
> sure about the 'options' argument to language_demangle.

Also, I'm not convinced that it's best for the unknown language
demangler to always return NULL.  Probably Adam's patch isn't too bad
in that regard: it will change the behavior of 'maint demangle', but
we can work around that if it's important, and it won't change the
behavior of fprintf_symbol_filtered; those are the only places where
Adam's patch actually calls language_demangler.  But, given that we
don't always reliably know the current language (and could conceivably
figure that out via demangling, modulo Java/C++ confusion), I'm not
convinced that returning NULL is the right thing.  (Or that it isn't
the right thing.)

David Carlton
carlton at math dot stanford dot edu


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]