This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Recent breakage -- disassemble



Ok, the problem is not that filtered prints were not used, but that
there is code in fputs_maybe_filtered to bypass the filtered print, if
this condition is true:

  /* Don't do any filtering if it is disabled.  */
  if ((stream != gdb_stdout) || !pagination_enabled
      || (lines_per_page == UINT_MAX && chars_per_line == UINT_MAX))
    {
      fputs_unfiltered (linebuffer, stream);
      return;
    }

In this case, stream is different from gdb_stdout.

Can you try this patch?

I think this patch has the potential for causing gdb_stdlog and gdb_stderr to also paginate. ui_file_isatty(gdb_stderr) also returns 1.


Andrew

Index: utils.c
===================================================================
RCS file: /cvs/uberbaum/gdb/utils.c,v
retrieving revision 1.99
diff -u -p -r1.99 utils.c
--- utils.c 2 Apr 2003 03:02:46 -0000 1.99
+++ utils.c 22 Apr 2003 14:28:00 -0000
@@ -1887,7 +1887,7 @@ fputs_maybe_filtered (const char *linebu
return;
/* Don't do any filtering if it is disabled. */
- if ((stream != gdb_stdout) || !pagination_enabled
+ if (!ui_file_isatty (stream) || !pagination_enabled
|| (lines_per_page == UINT_MAX && chars_per_line == UINT_MAX))
{
fputs_unfiltered (linebuffer, stream);









Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]