This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH/RFC] charset.c/charset.exp/doco updates
- From: Elena Zannoni <ezannoni at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Fri, 2 May 2003 10:29:09 -0400
- Subject: Re: [PATCH/RFC] charset.c/charset.exp/doco updates
- References: <16040.26062.97116.134556@localhost.redhat.com>
Elena Zannoni writes:
>
> Ok, here are the changes to make charset.c use the set/show mechanism
> with enums. Also, it now uses 'ASCII', 'ISO', 'IBM', 'EBDDIC' (which
> makes it consistent with the doco). This means that only uppercase
> charset names are used, and the case-insensitive string comparison
> function is no longer necessary.
>
> The other change is that 'show target-charset' shows now only the
> value of the target-charset variable, instead of showing both host and
> target. To see both host and target charsets, use 'show charset'.
> The 'show charset' command has not changed.
>
> Given that we use enums/set/show, we now have completion. Therefore if
> you type 'set charset <ENTER>' or 'set host-charset <ENTER>' or 'set
> target-charset <ENTER>' you get an error message. If you type any of
> the above followed by TAB-TAB you get the list of valid charsets.
> Note that since 'set charset' sets both the host and the target
> charsets to be the same, the completion on this command shows the
> intersection of the valid target charsets and the valid host
> charsets. Right now such intersection is just the host charset (I
> don't think there is much value in displaying all the possible
> charsets and then entering one that will be rejected).
>
> I updated the testsuite file and the doco as well.
>
> elena
>
>
committed