This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [branch patch] dwarf-frame.c support for .eh_frame_hdr
- From: Roland McGrath <roland at redhat dot com>
- To: Elena Zannoni <ezannoni at redhat dot com>
- Cc: Mark Kettenis <kettenis at gnu dot org>, gdb-patches at sources dot redhat dot com
- Date: Mon, 12 May 2003 20:42:48 -0700
- Subject: Re: [branch patch] dwarf-frame.c support for .eh_frame_hdr
> Is there a way to tell if there is a table?
Sure, my code does check that (size_of_encoded_value returns 0 in that
case). It's just that if there is no table, I don't think there is
anything else useful to try. AFAIK it's not a practical concern. It's
just something that struck me when I came across it.
> I see that the symfile.c change is a good way to test the code, and to
> verify that the stuff that ends up in the core file makes sense. This
> new add-symbol-file command required to read the symbols info from the
> core file is however a bit of a departure from the standard way core
> files are treated in gdb. It also not entirely clear to a user that
> it would be necessary to issue it.
I never suggested that users do such a thing. I did it myself to test the
dwarf-frame.c changes, and included the symfile.c patch so that other could
demonstrate for themselves that the .eh_frame_hdr decoding in fact works.
(If you catch up with your mailbox, you'll notice that today I posted the
patch I wrote later last night to implicitly do it for all core files.)
Thanks,
Roland