This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] update alpha return value hooks to regcache
- From: Mark Kettenis <kettenis at chello dot nl>
- To: Richard Henderson <rth at twiddle dot net>
- Cc: gdb-patches at sources dot redhat dot com
- Date: 02 Jun 2003 18:24:56 +0200
- Subject: Re: [RFA] update alpha return value hooks to regcache
- References: <20030602052612.GA7505@twiddle.net>
Richard Henderson <rth@twiddle.net> writes:
> Ok?
>
> r~
>
> * alpha-tdep.c (alpha_extract_return_value): Convert to regcache.
> (alpha_extract_struct_value_address): Likewise.
> (alpha_store_return_value): Likewise.
> (alpha_store_struct_return): Remove.
> (alpha_gdbarch_init): Update hook registration to match.
>
Ah, this one's got a flaw. Using abort() isn't allowed in GDB.
Instead use internal_error() which gives the user the option of
continuing at his/her own risk. You could also use gdb_assert()
(which calls internal_error()).
With that change, this is approved.
Mark