This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] cleanup alpha core read/write registers
On Mon, Jun 02, 2003 at 01:29:49PM -0700, Richard Henderson wrote:
> On Mon, Jun 02, 2003 at 11:19:37AM -0700, Richard Henderson wrote:
> > RFA because I'm touching systems I can't test.
> >
> > As far as alpha-nat is concerned, this gets rid of the use
> > of the deprecated register array. Indeed, there are no
> > longer *any* instances of "deprecated" in the alpha port.
> >
> > As far as Linux is concerned, this fixes the gcore test
> > because we now properly dump the FPCR and UNIQUE registers.
> >
> > As far as the BSD's are concerned, this should be a no-op,
> > just avoiding some amount of code duplication.
> >
> > Ok?
>
> Gah. This is the patch I meant to send.
I don't have anywhere to test it either, but it looks good. This
touches some code which would be triggered on Tru64, right? If so and
you're particularly nervous about it, ask Joel Brobecker to test it.
Otherwise I think it's OK to check in.
>
>
> r~
>
>
>
> * alpha-tdep.c (alpha_supply_int_regs, alpha_fill_int_regs): New.
> (alpha_supply_fp_regs, alpha_fill_fp_regs): New.
> * alpha-tdep.h: Declare them.
>
> * alpha-nat.c (fetch_osf_core_registers): Constify core_reg_mapping.
> Remove zerobuf. Don't error on UNIQUE.
> (fetch_elf_core_registers): Use alpha_supply_{int,fp}_regs.
> (ALPHA_REGSET_UNIQUE): Provide default.
> (supply_gregset): Use alpha_supply_int_regs.
> (fill_gregset): Use alpha_fill_int_regs.
> (supply_fpregset): Use alpha_supply_fp_regs.
> (fill_fpregset): Use alpha_fill_fp_regs.
> * alphabsd-tdep.c (NUM_GREGS, NUM_FPREGS): Remove.
> (alphabsd_supply_reg): Use alpha_supply_int_regs.
> (alphabsd_fill_reg): Use alpha_fill_int_regs.
> (alphabsd_supply_fpreg): Use alpha_supply_fp_regs.
> (alphabsd_fill_fpreg): Use alpha_fill_fp_regs.
> * config/alpha/nm-linux.h (ALPHA_REGSET_UNIQUE): New.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer