This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c
- From: Joel Brobecker <brobecker at gnat dot com>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com
- Date: Tue, 3 Jun 2003 23:05:12 -0700
- Subject: Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c
- References: <20030604002702.GP919@gnat.com> <3EDD5DAA.1060300@redhat.com>
> >2003-06-03 J. Brobecker <brobecker@gnat.com>
> >
> > * alpha-osf1-tdep.c (alpha_osf1_skip_sigtramp_frame): Replace
> > references to struct frame_info fields by calls to the equivalent
> > accessors. Necessary now that frame_info is opaque.
> > (alpha_osf1_pc_in_sigtramp): Likewise.
> >
> >Looks ok?
>
> Yes. If you're feeling game you could use get_frame_memory, but
> either way.
Andrew, please forgive for not having followed the discussions about
the new frame architecture too closely (I did go and read the messages
you recently pointed out to Daniel, though!).
You are saying either way; however, my current understanding is that
get_frame_memory is not currently any different from the above, but
is still a better approach in the long run if we eventually want to be
multi-everything. Is it correct?
I am not sure if it is really worth fixing this sort of thing now, or
worry about it later... You know the grand plan, so your call.
--
Joel