This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[commit] generic_target_write_sp -> deprecated_write_sp
- From: Andrew Cagney <ac131313 at redhat dot com>
- To: gdb-patches at sources dot redhat dot com
- Date: Sat, 07 Jun 2003 18:40:32 -0400
- Subject: [commit] generic_target_write_sp -> deprecated_write_sp
Hello,
Minor cleanup. Stop people getting ideas that it's ok to use
generic_target_write_sp.
committed,
Andrew
2003-06-07 Andrew Cagney <cagney@redhat.com>
* inferior.h (deprecated_write_sp): Replace
generic_target_write_sp.
* regcache.c (deprecated_write_sp): Replace
generic_target_write_sp.
* xstormy16-tdep.c (xstormy16_gdbarch_init): Update.
* vax-tdep.c (vax_gdbarch_init): Update.
* v850-tdep.c (v850_gdbarch_init): Update.
* sparc-tdep.c (sparc_gdbarch_init): Update.
* sh-tdep.c (sh_gdbarch_init): Update.
* s390-tdep.c (s390_gdbarch_init): Update.
* rs6000-tdep.c (rs6000_gdbarch_init): Update.
* ns32k-tdep.c (ns32k_gdbarch_init): Update.
* mn10300-tdep.c (mn10300_gdbarch_init): Update.
* mcore-tdep.c (mcore_gdbarch_init): Update.
* m68k-tdep.c (m68k_gdbarch_init): Update.
* m68hc11-tdep.c (m68hc11_gdbarch_init): Update.
* ia64-tdep.c (ia64_gdbarch_init): Update.
* h8300-tdep.c (h8300_gdbarch_init): Update.
* frv-tdep.c (frv_gdbarch_init): Update.
* cris-tdep.c (cris_gdbarch_init): Update.
* config/pa/tm-hppa.h (DEPRECATED_DUMMY_WRITE_SP): Update.
Index: cris-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/cris-tdep.c,v
retrieving revision 1.73
diff -u -r1.73 cris-tdep.c
--- cris-tdep.c 3 Jun 2003 01:24:41 -0000 1.73
+++ cris-tdep.c 7 Jun 2003 19:44:01 -0000
@@ -4308,7 +4308,7 @@
set_gdbarch_save_dummy_frame_tos (gdbarch, generic_save_dummy_frame_tos);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
/* Use target_specific function to define link map offsets. */
set_solib_svr4_fetch_link_map_offsets
Index: frv-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/frv-tdep.c,v
retrieving revision 1.41
diff -u -r1.41 frv-tdep.c
--- frv-tdep.c 7 Jun 2003 18:08:23 -0000 1.41
+++ frv-tdep.c 7 Jun 2003 19:44:01 -0000
@@ -1100,7 +1100,7 @@
set_gdbarch_inner_than (gdbarch, core_addr_lessthan);
set_gdbarch_write_pc (gdbarch, generic_target_write_pc);
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
set_gdbarch_deprecated_pc_in_call_dummy (gdbarch, deprecated_pc_in_call_dummy_at_entry_point);
Index: h8300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/h8300-tdep.c,v
retrieving revision 1.63
diff -u -r1.63 h8300-tdep.c
--- h8300-tdep.c 6 Jun 2003 18:48:08 -0000 1.63
+++ h8300-tdep.c 7 Jun 2003 19:44:06 -0000
@@ -1196,7 +1196,7 @@
set_gdbarch_believe_pcc_promotion (gdbarch, 1);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
return gdbarch;
}
Index: ia64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ia64-tdep.c,v
retrieving revision 1.81
diff -u -r1.81 ia64-tdep.c
--- ia64-tdep.c 7 Jun 2003 18:08:24 -0000 1.81
+++ ia64-tdep.c 7 Jun 2003 19:44:24 -0000
@@ -2313,7 +2313,7 @@
/* Settings that should be unnecessary. */
set_gdbarch_inner_than (gdbarch, core_addr_lessthan);
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
set_gdbarch_decr_pc_after_break (gdbarch, 0);
set_gdbarch_function_start_offset (gdbarch, 0);
Index: inferior.h
===================================================================
RCS file: /cvs/src/src/gdb/inferior.h,v
retrieving revision 1.57
diff -u -r1.57 inferior.h
--- inferior.h 7 Jun 2003 18:08:24 -0000 1.57
+++ inferior.h 7 Jun 2003 19:44:27 -0000
@@ -176,7 +176,7 @@
extern CORE_ADDR read_sp (void);
-extern void generic_target_write_sp (CORE_ADDR);
+extern void deprecated_write_sp (CORE_ADDR);
extern CORE_ADDR deprecated_read_fp (void);
Index: m68hc11-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68hc11-tdep.c,v
retrieving revision 1.71
diff -u -r1.71 m68hc11-tdep.c
--- m68hc11-tdep.c 7 Jun 2003 18:08:24 -0000 1.71
+++ m68hc11-tdep.c 7 Jun 2003 19:46:10 -0000
@@ -1366,7 +1366,7 @@
set_gdbarch_frame_args_skip (gdbarch, 0);
set_gdbarch_write_pc (gdbarch, generic_target_write_pc);
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
set_gdbarch_sp_regnum (gdbarch, HARD_SP_REGNUM);
set_gdbarch_deprecated_fp_regnum (gdbarch, SOFT_FP_REGNUM);
Index: m68k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68k-tdep.c,v
retrieving revision 1.65
diff -u -r1.65 m68k-tdep.c
--- m68k-tdep.c 2 Jun 2003 22:56:52 -0000 1.65
+++ m68k-tdep.c 7 Jun 2003 19:46:12 -0000
@@ -964,7 +964,7 @@
set_gdbarch_deprecated_pop_frame (gdbarch, m68k_pop_frame);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
/* Disassembler. */
set_gdbarch_print_insn (gdbarch, print_insn_m68k);
Index: mcore-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mcore-tdep.c,v
retrieving revision 1.64
diff -u -r1.64 mcore-tdep.c
--- mcore-tdep.c 2 Jun 2003 02:09:39 -0000 1.64
+++ mcore-tdep.c 7 Jun 2003 19:46:12 -0000
@@ -1159,7 +1159,7 @@
set_gdbarch_reg_struct_has_addr (gdbarch, mcore_reg_struct_has_addr);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
return gdbarch;
}
Index: mn10300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v
retrieving revision 1.79
diff -u -r1.79 mn10300-tdep.c
--- mn10300-tdep.c 7 Jun 2003 18:08:24 -0000 1.79
+++ mn10300-tdep.c 7 Jun 2003 19:46:12 -0000
@@ -1208,7 +1208,7 @@
tdep->am33_mode = am33_mode;
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
return gdbarch;
}
Index: ns32k-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/ns32k-tdep.c,v
retrieving revision 1.49
diff -u -r1.49 ns32k-tdep.c
--- ns32k-tdep.c 2 Jun 2003 02:09:39 -0000 1.49
+++ ns32k-tdep.c 7 Jun 2003 19:46:14 -0000
@@ -611,7 +611,7 @@
set_gdbarch_function_start_offset (gdbarch, 0);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
/* Hook in OS ABI-specific overrides, if they have been registered. */
gdbarch_init_osabi (info, gdbarch);
Index: regcache.c
===================================================================
RCS file: /cvs/src/src/gdb/regcache.c,v
retrieving revision 1.84
diff -u -r1.84 regcache.c
--- regcache.c 7 Jun 2003 18:08:24 -0000 1.84
+++ regcache.c 7 Jun 2003 19:46:16 -0000
@@ -1273,9 +1273,6 @@
they will use the contextual information provided by the FRAME.
These functions do not belong in the register cache. */
-/* NOTE: cagney/2003-06-07: The function generic_target_write_sp()
- should be deleted. */
-
/* NOTE: cagney/2003-06-07: The functions generic_target_write_pc(),
write_pc_pid(), write_pc(), and deprecated_read_fp(), all need to
be replaced by something that does not rely on global state. But
@@ -1361,17 +1358,10 @@
}
void
-generic_target_write_sp (CORE_ADDR val)
+deprecated_write_sp (CORE_ADDR val)
{
-#ifdef SP_REGNUM
- if (SP_REGNUM >= 0)
- {
- write_register (SP_REGNUM, val);
- return;
- }
-#endif
- internal_error (__FILE__, __LINE__,
- "generic_target_write_sp");
+ gdb_assert (SP_REGNUM >= 0);
+ write_register (SP_REGNUM, val);
}
CORE_ADDR
Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.138
diff -u -r1.138 rs6000-tdep.c
--- rs6000-tdep.c 7 Jun 2003 18:08:24 -0000 1.138
+++ rs6000-tdep.c 7 Jun 2003 19:46:18 -0000
@@ -2911,7 +2911,7 @@
set_gdbarch_print_insn (gdbarch, gdb_print_insn_powerpc);
set_gdbarch_write_pc (gdbarch, generic_target_write_pc);
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
set_gdbarch_num_regs (gdbarch, v->nregs);
set_gdbarch_num_pseudo_regs (gdbarch, v->npregs);
Index: s390-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/s390-tdep.c,v
retrieving revision 1.98
diff -u -r1.98 s390-tdep.c
--- s390-tdep.c 17 May 2003 05:59:58 -0000 1.98
+++ s390-tdep.c 7 Jun 2003 19:46:20 -0000
@@ -1911,7 +1911,7 @@
}
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
return gdbarch;
}
Index: sh-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sh-tdep.c,v
retrieving revision 1.127
diff -u -r1.127 sh-tdep.c
--- sh-tdep.c 7 Jun 2003 18:08:24 -0000 1.127
+++ sh-tdep.c 7 Jun 2003 19:46:25 -0000
@@ -4638,7 +4638,7 @@
}
set_gdbarch_write_pc (gdbarch, generic_target_write_pc);
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
set_gdbarch_register_name (gdbarch, sh_register_name);
set_gdbarch_register_virtual_type (gdbarch, sh_register_virtual_type);
Index: sparc-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/sparc-tdep.c,v
retrieving revision 1.109
diff -u -r1.109 sparc-tdep.c
--- sparc-tdep.c 7 Jun 2003 18:08:25 -0000 1.109
+++ sparc-tdep.c 7 Jun 2003 19:46:33 -0000
@@ -3440,7 +3440,7 @@
set_gdbarch_deprecated_store_struct_return (gdbarch, sparc32_store_struct_return);
set_gdbarch_use_struct_convention (gdbarch,
generic_use_struct_convention);
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
tdep->y_regnum = SPARC32_Y_REGNUM;
tdep->fp_max_regnum = SPARC_FP0_REGNUM + 32;
tdep->intreg_size = 4;
Index: v850-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/v850-tdep.c,v
retrieving revision 1.64
diff -u -r1.64 v850-tdep.c
--- v850-tdep.c 2 Jun 2003 02:09:40 -0000 1.64
+++ v850-tdep.c 7 Jun 2003 19:46:35 -0000
@@ -1288,7 +1288,7 @@
set_gdbarch_long_double_bit (gdbarch, 8 * TARGET_CHAR_BIT);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
return gdbarch;
}
Index: vax-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/vax-tdep.c,v
retrieving revision 1.51
diff -u -r1.51 vax-tdep.c
--- vax-tdep.c 2 Jun 2003 02:09:40 -0000 1.51
+++ vax-tdep.c 7 Jun 2003 19:46:35 -0000
@@ -435,7 +435,7 @@
set_gdbarch_believe_pcc_promotion (gdbarch, 1);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
/* Hook in ABI-specific overrides, if they have been registered. */
gdbarch_init_osabi (info, gdbarch);
Index: xstormy16-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xstormy16-tdep.c,v
retrieving revision 1.53
diff -u -r1.53 xstormy16-tdep.c
--- xstormy16-tdep.c 2 Jun 2003 02:09:40 -0000 1.53
+++ xstormy16-tdep.c 7 Jun 2003 19:46:36 -0000
@@ -1114,7 +1114,7 @@
xstormy16_in_solib_call_trampoline);
/* Should be using push_dummy_call. */
- set_gdbarch_deprecated_dummy_write_sp (gdbarch, generic_target_write_sp);
+ set_gdbarch_deprecated_dummy_write_sp (gdbarch, deprecated_write_sp);
return gdbarch;
}
Index: config/pa/tm-hppa.h
===================================================================
RCS file: /cvs/src/src/gdb/config/pa/tm-hppa.h,v
retrieving revision 1.52
diff -u -r1.52 tm-hppa.h
--- config/pa/tm-hppa.h 5 Jun 2003 23:45:15 -0000 1.52
+++ config/pa/tm-hppa.h 7 Jun 2003 19:46:37 -0000
@@ -25,7 +25,7 @@
#include "regcache.h"
/* Wonder if this is correct? Should be using push_dummy_call(). */
-#define DEPRECATED_DUMMY_WRITE_SP(SP) generic_target_write_sp (SP)
+#define DEPRECATED_DUMMY_WRITE_SP(SP) deprecated_write_sp (SP)
#ifndef GDB_MULTI_ARCH
#define GDB_MULTI_ARCH 1