This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [commit] remove DEPRECATED_SYMBOL_NAME uses from symtab.c
- From: David Carlton <carlton at math dot stanford dot edu>
- To: Andrew Cagney <ac131313 at redhat dot com>
- Cc: gdb-patches at sources dot redhat dot com, ezannoni at redhat dot com, jimb at redhat dot com
- Date: 12 Jun 2003 10:05:49 -0700
- Subject: Re: [commit] remove DEPRECATED_SYMBOL_NAME uses from symtab.c
- References: <m3isrbffz9.fsf@dhcp-10-42-69-238.kealia.com><3EE8B108.7020306@redhat.com>
On Thu, 12 Jun 2003 12:57:44 -0400, Andrew Cagney <ac131313@redhat.com> said:
> Does this:
>> #define COMPLETION_LIST_ADD_SYMBOL(symbol, sym_text, len, text, word) \
>> - do { \
>> - if (SYMBOL_DEMANGLED_NAME (symbol) != NULL) \
>> - /* Put only the mangled name on the list. */ \
>> - /* Advantage: "b foo<TAB>" completes to "b foo(int, int)" */ \
>> - /* Disadvantage: "b foo__i<TAB>" doesn't complete. */ \
>> completion_list_add_name \
>> - (SYMBOL_DEMANGLED_NAME (symbol), (sym_text), (len), (text), (word)); \
>> - else \
>> - completion_list_add_name \
>> - (DEPRECATED_SYMBOL_NAME (symbol), (sym_text), (len), (text), (word)); \
>> - } while (0)
>> + (SYMBOL_NATURAL_NAME (symbol), (sym_text), (len), (text), (word))
> mean that COMPLETION_LIST_ADD_SYMBOL is also dead? (I have trouble
> reading unified diffs :-)
No, it's still there, it's just defined as follows now:
#define COMPLETION_LIST_ADD_SYMBOL(symbol, sym_text, len, text, word) \
completion_list_add_name \
(SYMBOL_NATURAL_NAME (symbol), (sym_text), (len), (text), (word))
One could argue the wisdom of keeping it around as a separate macro,
but that's a separate issue: all I wanted to do with that patch was
clean up deprecated stuff.
David Carlton
carlton@math.stanford.edu