This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: RFA: gdb linux nptl patch 1
- From: Daniel Jacobowitz <drow at mvista dot com>
- To: Michael Snyder <msnyder at redhat dot com>
- Cc: "J. Johnston" <jjohnstn at redhat dot com>, gdb-patches at sources dot redhat dot com
- Date: Wed, 18 Jun 2003 19:11:49 -0400
- Subject: Re: RFA: gdb linux nptl patch 1
- References: <3E84E672.3050506@redhat.com> <3EF0F0DF.2030802@redhat.com>
On Wed, Jun 18, 2003 at 04:08:15PM -0700, Michael Snyder wrote:
> J. Johnston wrote:
> [...]
> >This patch proposes adding a secondary list of thread_info structs that
> >keeps
> >track of the lwps. This list is kept distinct from the regular thread
> >list.
> >Since manipulating either list involves common operations, some base
> >operations
> >are added for generic thread_info list manipulation. The lin-lwp.c
> >layer is
> >changed to add and delete lwp thread_info structs to the lwp list when lwps
> >are added or deleted. The linux-proc.c code is changed to iterate
> >through the
> >lwp thread_info list rather than the thread list when creating the
> >pr_status
> >notes.
>
> Jeff, did you realize that lin-lwp.c already maintains a list of lwps?
> It even exports an iterator function. I think this list you're adding
> may be redundant.
It exports an iterator, but you can't usefully declare the iterator's
callback anywhere, since struct lwp_info is local to lin-lwp.c...
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer