This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] partial fix for PR gdb/1245
On Sun, 29 Jun 2003 17:06:42 -0400, Daniel Jacobowitz <drow@mvista.com> said:
> Yes, this is OK as a bandaid. As I explained in the PR, we can
> correctly handle this, but not asserting is good enough for the
> moment.
Great, thanks. Though I just sent a reply to the PR saying that I
disagree with you about what fix is correct, but never mind that; it's
really not a high priority issue once this patch goes in, I think.
>> case ')':
>> + if (permissive)
>> + {
>> + return index;
>> + }
> Please drop the useless pair of braces.
I guess I did that to balance the else clause, but I'm happy to do it
your way.
Committed on mainline and branch.
David Carlton
carlton@kealia.com